Pipes - Bennett - Muncher #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h indexes and show
… and some styling.
API MuncherWhat We're Looking For
|
| url = BASE_URL + "q=" + query + ID_AND_KEY + paginate(from) | ||
| data = HTTParty.get(url) | ||
| unless data["hits"].empty? | ||
| data["hits"].each do |hit_data| |
There was a problem hiding this comment.
You shouldn't need the unless statement here - if data["hits"] is empty, then data["hits"].each will iterate zero times.
| must_redirect_to root_path | ||
| flash[:message].must_equal "Invalid input: please try again without symobls." | ||
| end | ||
| end |
There was a problem hiding this comment.
I know pagination isn't working, but there are a few test cases around it that I would like to see here:
- Make sure paging parameters are accepted, and that requesting a different page doesn't break things
- What if the paging parameters are invalid (negative number, etc)?
- What if the paging parameters take you past the end of the available search results?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Muncher
Congratulations! You're submitting your assignment!
Comprehension Questions
This does not represent a necessarily finished project, I didn't finish the pagination or various other things, but its good enough and I'm done. For now.